Add option for ICE servers to be client only #3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3164 +/- ##
==========================================
+ Coverage 55.65% 55.69% +0.03%
==========================================
Files 151 151
Lines 16874 16875 +1
==========================================
+ Hits 9391 9398 +7
+ Misses 6744 6738 -6
Partials 739 739 ☔ View full report in Codecov by Sentry. |
dbason
force-pushed
the
optional-server-ice
branch
from
0a5b155
to
b574839
Compare
dbason
force-pushed
the
optional-server-ice
branch
from
b574839
to
94efd0f
Compare
|
I think there might be a race condition in the failing test. I have noticed that one other open PR is also failing on the same thing. |
|
merged, thanks! |
|
This issue is mentioned in release v1.7.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3145
The config update will not change the default behaviour. It does however allow the asymmetric model. This is how LiveKit uses TURN servers for example.